Update TutorialReact.md #5949
Update TutorialReact.md #5949
Conversation
The current docs imply you can use Jest snapshots with create-react-app 'out-the-box', however the Snapshot Testing example doesn't work with a fresh install. You need to additionally install `react-test-renderer` as a dependency. I thought it was more helpful to change the docs, but if it's better to raise the issue elsewhere let me know?!
The current docs imply you can use Jest snapshots with create-react-app 'out-the-box', however the Snapshot Testing example doesn't work with a fresh install. You need to additionally install `react-test-renderer` as a dependency. I thought it was more helpful to change the docs, but if it's better to raise the issue elsewhere let me know?!
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Looks good, @atomcorp can you run |
|
Thanks for the swift reply! |
|
You don't need to run the tests for a documentation change. Can you make sure to run |
|
Fair enough! I was hoping to check before pushing broken commits :( I did run |
Codecov Report
@@ Coverage Diff @@
## master #5949 +/- ##
=======================================
Coverage 64.39% 64.39%
=======================================
Files 217 217
Lines 8274 8274
Branches 3 4 +1
=======================================
Hits 5328 5328
Misses 2945 2945
Partials 1 1Continue to review full report at Codecov.
|
|
Thanks! |
|
Haha, OK guess I didn't |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The current docs imply you can use Jest snapshots with create-react-app 'out-the-box', however the Snapshot Testing example doesn't work with a fresh install. You need to additionally install
react-test-rendereras a dependency.I thought it was more helpful to change the docs, but if it's better to raise the issue elsewhere let me know!
Summary
The docs are a little confusing. It literally says Create React App works without any additional configuration, however one of the examples provided doesn't work without additional configuaration.
Test plan
I did a fresh install of the latest create-react-app, created the Link.react.app and Link.react.test.js from the docs example and tried to run the tests. It fails unless you add 'react-test-renderer'.