Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use prettylint for markdown #5651

Merged
merged 1 commit into from
Feb 24, 2018
Merged

use prettylint for markdown #5651

merged 1 commit into from
Feb 24, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 24, 2018

Summary

Uses prettylint instead of prettier --list-different.

See difference when invoking them (ignore command in the middle wihout quotes, I hit ^C and was too lazy to clean it up 😅):

image

(current behavior has already caused confusion: #5648).

Test plan

N/A

@codecov-io
Copy link

Codecov Report

Merging #5651 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5651   +/-   ##
=======================================
  Coverage   62.35%   62.35%           
=======================================
  Files         216      216           
  Lines        7908     7908           
  Branches        4        4           
=======================================
  Hits         4931     4931           
  Misses       2976     2976           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64cbf36...13550fe. Read the comment docs.

@SimenB
Copy link
Member Author

SimenB commented Feb 24, 2018

Should we start having precommit hooks?

@cpojer cpojer merged commit c88da54 into jestjs:master Feb 24, 2018
@rickhanlonii
Copy link
Member

Way better 💯

@SimenB SimenB deleted the prettylint branch February 24, 2018 14:28
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants