Replace path sep for testRegex in should_instrument #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so test files don't get instrumented on windows given a pattern like /__tests__/*.js
thymikee
reviewed
Feb 14, 2018
| if (config.testRegex && filename.match(config.testRegex)) { | ||
| if ( | ||
| config.testRegex && | ||
| new RegExp(replacePathSepForRegex(config.testRegex)).test(filename) |
There was a problem hiding this comment.
Shouldn't we normalize this in normalize.js?
There was a problem hiding this comment.
Moved to normalize and dropped from search_source as well.
SimenB
reviewed
Feb 14, 2018
CHANGELOG.md
Outdated
| ### Fixes | ||
|
|
||
| * `[jest-runtime]` Replace path sep for testRegex in should_instrument so test | ||
| files don't get instrumented on windows given a pattern like /__tests__/*.js |
There was a problem hiding this comment.
you need to stick /__tests__/ in backticks (or escape using backslash as I've done in this comment), if not markdown looks really weird
# Conflicts: # integration-tests/__tests__/coverage_remapping.test.js
thymikee
approved these changes
Feb 15, 2018
|
Loving all the windows fixes, keep 'em coming. |
This was referenced Feb 20, 2018
This was referenced Mar 1, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test files on windows shouldn't get instrumented given a testRegex like
"/__tests__/*.js"This matches what jest-cli does here https://github.com/facebook/jest/blob/c5fbd304c462e3c74c6cc5f5e7484e466c10521e/packages/jest-cli/src/search_source.js#L94
Test plan
Removed SkipOnWindows from the coverage_remapping integration test, which was failing for this reason, so green Appveyor.