Fix recursive process.exit calls #5445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea on how can this break |
SimenB
reviewed
Feb 3, 2018
| @@ -11,7 +11,6 @@ import type {Argv} from 'types/Argv'; | |||
| import type {EnvironmentClass} from 'types/Environment'; | |||
|
|
|||
| import chalk from 'chalk'; | |||
| import exit from 'exit'; | |||
There was a problem hiding this comment.
should it be removed from dependencies as well? Some quick grepping says yes
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
process.exitCodeinstead of recursively callingprocess.exit()on aexitevent.Fixes #5332. The reason why it stopped working when merged #5313 is because on every single call to
process.exit(), theprocess.exitCodeis checked just before exiting. However theexitmodule implementation does not do that, so the code was never set.In turn, looking at the
process.exitimplementation, it is clear that callingprocess.exit()from anexitevent will have no effect but changing the exit code. Thus we can safely remove the secondexit()call and only modify the exit code, so that the native method picks it. A bit confusing, I know.