Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain which snapshots are obsolete #5020

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Explain which snapshots are obsolete #5020

merged 1 commit into from
Dec 6, 2017

Conversation

zouxuoz
Copy link
Contributor

@zouxuoz zouxuoz commented Dec 5, 2017

Summary

Resolve #5005

Test plan

image

@zouxuoz
Copy link
Contributor Author

zouxuoz commented Dec 5, 2017

@cpojer @SimenB @thymikee what are you think about UX? Maybe we should add flag for that?)

@codecov-io
Copy link

codecov-io commented Dec 5, 2017

Codecov Report

Merging #5020 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5020      +/-   ##
==========================================
- Coverage   60.44%   60.42%   -0.03%     
==========================================
  Files         198      198              
  Lines        6634     6640       +6     
  Branches        4        4              
==========================================
+ Hits         4010     4012       +2     
- Misses       2624     2628       +4
Impacted Files Coverage Δ
.../src/legacy_code_todo_rewrite/jest_adapter_init.js 0% <ø> (ø) ⬆️
packages/jest-cli/src/test_scheduler.js 25.54% <ø> (ø) ⬆️
packages/jest-jasmine2/src/index.js 5.71% <0%> (-0.17%) ⬇️
packages/jest-snapshot/src/State.js 0% <0%> (ø) ⬆️
packages/jest-cli/src/test_result_helpers.js 12.5% <0%> (-0.41%) ⬇️
...ages/jest-cli/src/reporters/get_snapshot_status.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc075c1...ef1f3d7. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a surprisingly elegant solution! I like it :)

(Could you update the changelog? :D)

@zouxuoz
Copy link
Contributor Author

zouxuoz commented Dec 6, 2017

@SimenB Updated 😉

@cpojer cpojer merged commit 3db5428 into jestjs:master Dec 6, 2017
@cpojer
Copy link
Member

cpojer commented Dec 6, 2017

This is great work. Thanks @zouxuoz

@crubier
Copy link

crubier commented Dec 6, 2017

Wow 2 days from issue to PR merge, amazing, I love jest ! Thanks @zouxuoz and @cpojer !

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain which snapshots are obsolete
6 participants