Format markdown files with Prettier #4853
Conversation
|
Wow, this is quite extreme but I like it. What do we propose to do in the meantime? Shall we close this PR and wait until prettier is done with all the fixes? Please exclude the README.md, that one is supposed to be autogenerated from the documentation (not sure if it still is). |
SimenB
force-pushed
the
prettier-1.8-md
branch
from
aee0dfd to
356469a
Compare
|
Thanks for raising those issues - we'll get them sorted and publish 1.8.1 asap. |
.github/ISSUE_TEMPLATE.md
Outdated
| <!-- | ||
| Before creating an issue please check the following: | ||
| * you are using the latest version of Jest | ||
| * try re-installing your node_modules folder | ||
| * run Jest once with `--no-cache` to see if that fixes the problem you are experiencing. | ||
| --> | ||
|
|
||
| **Do you want to request a *feature* or report a *bug*?** | ||
| **Do you want to request a _feature_ or report a *bug*?** |
There was a problem hiding this comment.
Not sure why *feature* changed but *bug* didn't? Or is it manual change?
Codecov Report
@@ Coverage Diff @@
## master #4853 +/- ##
=======================================
Coverage 59.64% 59.64%
=======================================
Files 194 194
Lines 6502 6502
Branches 3 3
=======================================
Hits 3878 3878
Misses 2624 2624Continue to review full report at Codecov.
|
|
Published |
|
Looks, like there's a PR tackling this last issue (prettier/prettier#3187). I guess we can wait a bit more then. |
SimenB
force-pushed
the
prettier-1.8-md
branch
from
7b387c1 to
5148078
Compare
|
Pushed a new commit which is done from master, but applied on top of 1.8.0 markdown output for easier diff |
|
Let me know when this is ready to merge guys. |
| @@ -142,5 +142,10 @@ | |||
| "testMatch": [ | |||
| "**/*.test.js" | |||
| ] | |||
| }, | |||
| "prettier": { | |||
There was a problem hiding this comment.
@thymikee could you test if this makes any of the config here unnecessary?
There was a problem hiding this comment.
It was cleaner to put it here instead of inline in the run script
There was a problem hiding this comment.
We should be safe to remove all of these except for prettier.eslintIntegration, because eslint --fix is responsible for formatting.
There was a problem hiding this comment.
Read the prettier-vscode docs, and the config in there is actually ignored if there's a prettier key in package.json.
(I don't use vscode, which is why I ask :))
SimenB
force-pushed
the
prettier-1.8-md
branch
from
333553c to
b4f0a15
Compare
SimenB
force-pushed
the
prettier-1.8-md
branch
from
b4f0a15 to
d97388c
Compare
|
@cpojer could you merge before conflicts arise? :D |
|
Done. |
|
Woo! Would you be opposed to commit hooks? |
|
Just a friendly reminder that commit hooks with Prettier might get terrible while rebasing. |
|
True story. Might be enough to periodically prettify |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Extracted from #4852 to allow that to be merged.
IMO, this is blocked by:
and possibly
*is converted into_prettier/prettier#3170Test plan
Pretty md