Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vscode): ease flow usage #4569

Merged
merged 2 commits into from
Sep 30, 2017
Merged

chore(vscode): ease flow usage #4569

merged 2 commits into from
Sep 30, 2017

Conversation

vvo
Copy link
Contributor

@vvo vvo commented Sep 30, 2017

Summary

image

Following https://github.com/flowtype/flow-for-vscode#setup they recommend setting "javascript.validate.enable": false in workspace settings, otherwise I get errors like "... can only be used in a .ts file".

As I am new to flow and vscode I might be wrong, let me know vscode users contributing to Jest how it works for you today?

Test plan

None, it's an editor setting

Following https://github.com/flowtype/flow-for-vscode#setup they recommend setting `"javascript.validate.enable": false` in workspace settings, otherwise I get errors like "... can only be used in a .ts file".

As I am new to flow and vscode I might be wrong, let me know vscode users contributing to Jest how it works for you today?
@codecov-io
Copy link

codecov-io commented Sep 30, 2017

Codecov Report

Merging #4569 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4569   +/-   ##
=======================================
  Coverage   56.16%   56.16%           
=======================================
  Files         185      185           
  Lines        6285     6285           
  Branches        3        3           
=======================================
  Hits         3530     3530           
  Misses       2754     2754           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af7bef...1527bea. Read the comment docs.

@vvo
Copy link
Contributor Author

vvo commented Sep 30, 2017

Should we also add "flow.useNPMPackagedFlow": true so it uses the default flow-bin rather than a global one?

@cpojer
Copy link
Member

cpojer commented Sep 30, 2017

cc @orta please advice :)

@orta
Copy link
Member

orta commented Sep 30, 2017

Yep, this is recommended for the plugin 👍

And yes, "flow.useNPMPackagedFlow": true should get added too IMO

@cpojer cpojer merged commit cfe1a9a into jestjs:master Sep 30, 2017
tabrindle pushed a commit to tabrindle/jest that referenced this pull request Oct 2, 2017
* chore(vscode): ease flow usage

Following https://github.com/flowtype/flow-for-vscode#setup they recommend setting `"javascript.validate.enable": false` in workspace settings, otherwise I get errors like "... can only be used in a .ts file".

As I am new to flow and vscode I might be wrong, let me know vscode users contributing to Jest how it works for you today?

* Update settings.json
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants