-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(vscode): ease flow usage #4569
Conversation
Following https://github.com/flowtype/flow-for-vscode#setup they recommend setting `"javascript.validate.enable": false` in workspace settings, otherwise I get errors like "... can only be used in a .ts file". As I am new to flow and vscode I might be wrong, let me know vscode users contributing to Jest how it works for you today?
Codecov Report
@@ Coverage Diff @@
## master #4569 +/- ##
=======================================
Coverage 56.16% 56.16%
=======================================
Files 185 185
Lines 6285 6285
Branches 3 3
=======================================
Hits 3530 3530
Misses 2754 2754
Partials 1 1 Continue to review full report at Codecov.
|
Should we also add |
cc @orta please advice :) |
Yep, this is recommended for the plugin 👍 And yes, |
* chore(vscode): ease flow usage Following https://github.com/flowtype/flow-for-vscode#setup they recommend setting `"javascript.validate.enable": false` in workspace settings, otherwise I get errors like "... can only be used in a .ts file". As I am new to flow and vscode I might be wrong, let me know vscode users contributing to Jest how it works for you today? * Update settings.json
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Following https://github.com/flowtype/flow-for-vscode#setup they recommend setting
"javascript.validate.enable": false
in workspace settings, otherwise I get errors like "... can only be used in a .ts file".As I am new to flow and vscode I might be wrong, let me know vscode users contributing to Jest how it works for you today?
Test plan
None, it's an editor setting