Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip inconsistent stack trace lines #3222

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Strip inconsistent stack trace lines #3222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions integration_tests/__tests__/failures-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,30 @@ const dir = path.resolve(__dirname, '../failures');

skipOnWindows.suite();

// Some node versions add an extra line to the error stack trace. This makes
// snapshot tests fail on different machines. This function makes sure
// this extra line is always removed.
const stripInconsistentStackLines = summary => {
summary.rest = summary.rest.replace(/\n^.*process\._tickCallback.*$/gm, '');
return summary;
};

test('throwing not Error objects', () => {
let stderr;
stderr = runJest(dir, ['throw-number-test.js']).stderr;
expect(extractSummary(stderr)).toMatchSnapshot();
expect(stripInconsistentStackLines(
extractSummary(stderr),
)).toMatchSnapshot();
stderr = runJest(dir, ['throw-string-test.js']).stderr;
expect(extractSummary(stderr)).toMatchSnapshot();
expect(stripInconsistentStackLines(
extractSummary(stderr),
)).toMatchSnapshot();
stderr = runJest(dir, ['throw-object-test.js']).stderr;
expect(extractSummary(stderr)).toMatchSnapshot();
expect(stripInconsistentStackLines(
extractSummary(stderr),
)).toMatchSnapshot();
stderr = runJest(dir, ['assertion-count-test.js']).stderr;
expect(extractSummary(stderr)).toMatchSnapshot();
expect(stripInconsistentStackLines(
extractSummary(stderr),
)).toMatchSnapshot();
});