fix(jest-snapshot): move @types/prettier to devDependencies #14328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
@types/prettier
todevDependencies
to avoid conflicts with typescript projects usingprettier>2.1.5
.Summary
I've been working on a project that uses TypeScript and Prettier directly, while working with it there were a few issues regarding the types (
check
andformat
functions).I'm using
[email protected]
and[email protected]
for testing. After getting some warnings about the types on my IDE, and given that prettier already ships it's own types I decided to check around, turns out thatjest-snapshot
was listing@types/prettier
as a dependency. Not only that, but it's[email protected]
so that were giving me erroneous warnings and IDE hints.I don't see a reason to have
@types/prettier
as adependency
instead of adevDependency
so...Test plan