refactor(jest-mock)!: rework Mocked* utility types
#13123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Aug 12, 2022
| export type MockedClass<T extends ClassLike> = MockInstance< | ||
| (args: T extends new (...args: infer P) => any ? P : never) => InstanceType<T> | ||
| > & { | ||
| prototype: T extends {prototype: any} ? Mocked<T['prototype']> : never; |
There was a problem hiding this comment.
Might be this could be a solution for MockedClassShallow. Although I am in doubt if it is worse to make types more complicated than proposed in this PR.
Comment on lines
-50
to
-52
| // TODO Figure out how to replace this with TS ConstructorParameters utility type | ||
| // https://www.typescriptlang.org/docs/handbook/utility-types.html#constructorparameterstype | ||
| type ConstructorParameters<T> = T extends new (...args: infer P) => any |
|
Thanks!! This is awesome |
This was referenced Aug 12, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #12727
Summary
As noted in #13117 (comment),
jest.mocked()does not work well with classes.This PR is major refactor of
Mocked*types which cleans up the implementation and solves the above mentioned issue.To clean up exports the
Mocked*utility types are renamed.MaybeMockedDeepandMaybeMockedbecameMockedandMockedShallowrespectively. Also only deep mocked variants ofMockedClass,MockedFunctionandMockedObjectare exported.Test plan
Lost of type tests added.