fix(jest-circus): reverse order of afterEach, afterAll hooks #12861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #12678
Currently, jest-circus runs
afterAll
andafterEach
hooks in declaration order. However, both the docs and jasmine2 show afterAll and afterEach hooks running in reverse declaration order. This makes intuitive sense when usingbeforeEach
to set up resources, andafterEach
to dispose of resources:This PR reverses the order of
afterAll
andafterEach
hooks before they are executed.Test plan
I added a snapshot test to jest-circus that emits output in the order shown in the documentation: https://jestjs.io/docs/setup-teardown#scoping