Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<C-u> to clear watch mode pattern prompt #11296 #11345

Closed
wants to merge 1 commit into from

Conversation

madhur1846
Copy link

Summary

Many users will expect Ctrl+u to behave as elsewhere in their terminal environment.
The workaround requires pressing backspace a lot to clear the line manually.

@facebook-github-bot
Copy link
Contributor

Hi @madhur1846!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #11345 (184d795) into master (b3f9e4a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11345      +/-   ##
==========================================
- Coverage   64.24%   64.24%   -0.01%     
==========================================
  Files         308      308              
  Lines       13502    13507       +5     
  Branches     3289     3289              
==========================================
+ Hits         8675     8677       +2     
- Misses       4117     4121       +4     
+ Partials      710      709       -1     
Impacted Files Coverage Δ
packages/jest-watcher/src/constants.ts 66.66% <ø> (ø)
packages/jest-watcher/src/lib/Prompt.ts 66.66% <0.00%> (-6.81%) ⬇️
packages/expect/src/utils.ts 96.12% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f9e4a...184d795. Read the comment docs.

@madhur1846
Copy link
Author

i have agreed the terms now what i have to do. Do i need to re push this commit?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Apr 30, 2021

Ergh, I just merged #11358 which was opened after this one. Sorry @madhur1846! Would you be up for sending a PR for moving forwards and backwards as I mention in #11296 (comment)?

/cc @jeysal

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants