-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<C-u> to clear watch mode pattern prompt #11296 #11345
Conversation
Hi @madhur1846! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #11345 +/- ##
==========================================
- Coverage 64.24% 64.24% -0.01%
==========================================
Files 308 308
Lines 13502 13507 +5
Branches 3289 3289
==========================================
+ Hits 8675 8677 +2
- Misses 4117 4121 +4
+ Partials 710 709 -1
Continue to review full report at Codecov.
|
i have agreed the terms now what i have to do. Do i need to re push this commit? |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Ergh, I just merged #11358 which was opened after this one. Sorry @madhur1846! Would you be up for sending a PR for moving forwards and backwards as I mention in #11296 (comment)? /cc @jeysal |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Many users will expect Ctrl+u to behave as elsewhere in their terminal environment.
The workaround requires pressing backspace a lot to clear the line manually.