Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no longer detecting enumerable when add domain #10862

Merged
merged 4 commits into from
Nov 25, 2020
Merged

no longer detecting enumerable when add domain #10862

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3787f9d
refactor(jest-util): no longer detecting enumerable when add domain
mapleeit Nov 24, 2020
d99f884
chore: add changelog
mapleeit Nov 24, 2020
136c08a
Update CHANGELOG.md
SimenB Nov 25, 2020
8206085
Update CHANGELOG.md
SimenB Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions packages/jest-util/src/createProcessObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,17 +112,11 @@ export default function (): NodeJS.Process {
newProcess.env = createProcessEnv();
newProcess.send = () => {};

const domainPropertyDescriptor = Object.getOwnPropertyDescriptor(
newProcess,
'domain',
);
if (domainPropertyDescriptor && !domainPropertyDescriptor.enumerable) {
Object.defineProperty(newProcess, 'domain', {
get() {
return process.domain;
},
});
}
Object.defineProperty(newProcess, 'domain', {
get() {
return process.domain;
},
});

return newProcess;
}