Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the stale information about node-gyp & python #10181

Merged
merged 2 commits into from
Jun 23, 2020
+1 −1
Merged

Fix the stale information about node-gyp & python #10181

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eae8b9
Fix the stale information about node-gyp & python
xamgore Jun 20, 2020
15ad5a0
Remove python versions in CONTRIBUTING.md
xamgore Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ _Before_ submitting a pull request, please make sure the following is done…

1. Jest uses [Yarn](https://code.facebook.com/posts/1840075619545360) for running development scripts. If you haven't already done so, please [install yarn](https://yarnpkg.com/en/docs/install).

1. Make sure you have `python` installed (v2.7 is recommended, v3.x.x is not supported). Python is required by [node-gyp](https://github.com/nodejs/node-gyp) that is used when running `yarn install`.
1. Make sure you have `python` installed (v3.x is recommended, v2.7 [is not](https://www.python.org/doc/sunset-python-2/)). Python is required by [node-gyp](https://github.com/nodejs/node-gyp) that is used when running `yarn install`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.7 is still supported by node-gyp, maybe we could just say

Make sure you have python installed. Python is required by node-gyp that is used when running yarn install.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


To check your version of Python and ensure it's installed you can type:

Expand Down