-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make reporters respect useStderr option #10054
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Test seems flaky on my machine
kenrick95
changed the title
WIP: [Attempt] fix: make reporters respect useStderr option
fix: make reporters respect useStderr option
May 17, 2020
Closing this since the change was too big to review, and takes too much effort to maintain the branch |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt to fix #5064 which is built on top of #6583
I do apologize for the huge PR which contains lots of commits and lots of files changed. I will help to rebase/solve conflicts if such need arise.
default_reporter.ts
andsummary_reporter.ts
to usefor .. of
instead offorEach
because inforEach
the scope ofthis
gets rewired to undefined when callingBaseReporter.log
stderr
tostdout
stderr
is still used when the run is triggered with--json
--useStderr
to preserve the old tests. Some places do rely on solely printing tostdout
and therefore the results need to be piped away (or to be regexed heavily). At such places where--useStderr
is used, I added a commentAs per 2020-05-17, I think I've fixed most of the test failures 🤞 I can only guess some of my fixes as I'm running on a Windows machine and couldn't reproduce those errors to fix (those tests are skipped on Windows)
Update 2020-05-18, all tests are passing now 🎉 but not sure how the maintainers can review 😅
Test plan
I believe in CIs