Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid watch-notification flood in NotifySend #8773

Closed
ildella opened this issue Aug 1, 2019 · 3 comments · Fixed by #11733
Closed

Avoid watch-notification flood in NotifySend #8773

ildella opened this issue Aug 1, 2019 · 3 comments · Fixed by #11733

Comments

@ildella
Copy link

ildella commented Aug 1, 2019

🚀 Feature Proposal

Support transient notifications on NotifySend (Linux notifications) so the Notification Panel UI is not flooded by Jest notifications.

Motivation

Wach/Notify is really useful.
I use it on Ubuntu/Gnome all the time.
After a full day of work, all the notifications, which can be a LOT, are accumulated in the Gnome notifications UI. Open that UI now takes a very long time, and the panel is flooded by Jest notifications, which is not nice.

Example

Just work a whole day with Jest watch and notifications enabled.

Pitch

The solution would be to make the notification of NotifySend transient, at least as an option.

The underlying implementation using node-notifier would be this:

notifier.notify({
    title: 'Disappear',
    message: 'magic',
    hint: 'int:transient:1',
  })

The hint: 'int:transient:1' would do the trick. The notification will then appear but will not stay in the Notification panel, so there will be no clutter or slow load time afterwards.

@ildella ildella changed the title Watch notification flood NotifySend in Ubuntu/Gnome Avoid watch-notification flood in NotifySend Aug 1, 2019
@jeysal
Copy link
Contributor

jeysal commented Aug 5, 2019

Makes sense to me, even as the default behavior. Wanna send a PR? notify_reporter should be the relevant file.

BudgieInWA added a commit to BudgieInWA/jest that referenced this issue Aug 5, 2021
Under GNOME Shell, using `--notify` (especially with `--watch`) floods the notification UI with unnecessary persistent copies of each notification that is raised. See jestjs#8773.

This change uses [the `notify-send` `hint` option](https://www.npmjs.com/package/node-notifier#usage-notifysend) [`int:transient:1`](https://askubuntu.com/a/1185741) to make the notification transient.
BudgieInWA added a commit to BudgieInWA/jest that referenced this issue Aug 5, 2021
Under GNOME Shell, using `--notify` (especially with `--watch`) floods the notification UI with unnecessary persistent copies of each notification that is raised. See jestjs#8773.

This change uses [the `notify-send` `hint` option](https://www.npmjs.com/package/node-notifier#usage-notifysend) [`int:transient:1`](https://askubuntu.com/a/1185741) to make the notification transient.
@SimenB
Copy link
Member

SimenB commented Mar 1, 2022

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants