Move Options.coverage to ProjectWorkspace.collectCoverage (#5929)

* update type definitions * Move `Options.coverage` to `ProjectWorkspace.collectCoverage` * mark collectCoverage as optional * fix failing test * update changelog
jestjs · Apr 9, 2018 · f6ae2cb · f6ae2cb
1 parent aa9790d
commit f6ae2cb
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ### Features
 
+* `[jest-editor-support]` Move `coverage` to `ProjectWorkspace.collectCoverage`
+  ([#5929](https://github.com/facebook/jest/pull/5929))
 * `[jest-editor-support]` Add `coverage` option to runner
   ([#5836](https://github.com/facebook/jest/pull/5836))
 * `[jest-haste-map]` Support extracting dynamic `import`s

diff --git a/packages/jest-editor-support/index.d.ts b/packages/jest-editor-support/index.d.ts
@@ -13,7 +13,6 @@ export interface SpawnOptions {
 }
 
 export interface Options {
-  coverage?: boolean;
   createProcess?(
     workspace: ProjectWorkspace,
     args: string[],
@@ -49,11 +48,13 @@ export class ProjectWorkspace {
     pathToJest: string,
     pathToConfig: string,
     localJestMajorVersin: number,
+    collectCoverage?: boolean,
   );
   pathToJest: string;
   pathToConfig: string;
   rootPath: string;
   localJestMajorVersion: number;
+  collectCoverage?: boolean;
 }
 
 export interface IParseResults {

diff --git a/packages/jest-editor-support/src/Runner.js b/packages/jest-editor-support/src/Runner.js
@@ -66,10 +66,10 @@ export default class Runner extends EventEmitter {
     if (this.options.testFileNamePattern) {
       args.push(this.options.testFileNamePattern);
     }
-    if (this.options.coverage === true) {
+    if (this.workspace.collectCoverage === true) {
       args.push('--coverage');
     }
-    if (this.options.coverage === false) {
+    if (this.workspace.collectCoverage === false) {
       args.push('--no-coverage');
     }
     if (this.options.noColor === true) {

diff --git a/packages/jest-editor-support/src/__tests__/runner.test.js b/packages/jest-editor-support/src/__tests__/runner.test.js
@@ -183,8 +183,8 @@ describe('Runner', () => {
     it('calls createProcess with the --coverage arg when provided', () => {
       const expected = '--coverage';
 
-      const workspace: any = {};
-      const options = {coverage: true};
+      const workspace: any = {collectCoverage: true};
+      const options = {};
       const sut = new Runner(workspace, options);
       sut.start(false);
 
@@ -196,8 +196,8 @@ describe('Runner', () => {
     it('calls createProcess with the ---no-coverage arg when provided and false', () => {
       const expected = '--no-coverage';
 
-      const workspace: any = {};
-      const options = {coverage: false};
+      const workspace: any = {collectCoverage: false};
+      const options = {};
       const sut = new Runner(workspace, options);
       sut.start(false);
 

diff --git a/packages/jest-editor-support/src/project_workspace.js b/packages/jest-editor-support/src/project_workspace.js
@@ -46,15 +46,24 @@ export default class ProjectWorkspace {
    */
   localJestMajorVersion: number;
 
+  /**
+   * Whether test coverage should be (automatically) collected.
+   *
+   * @type {boolean}
+   */
+  collectCoverage: ?boolean;
+
   constructor(
     rootPath: string,
     pathToJest: string,
     pathToConfig: string,
     localJestMajorVersion: number,
+    collectCoverage: ?boolean,
   ) {
     this.rootPath = rootPath;
     this.pathToJest = pathToJest;
     this.pathToConfig = pathToConfig;
     this.localJestMajorVersion = localJestMajorVersion;
+    this.collectCoverage = collectCoverage;
   }
 }
diff --git a/packages/jest-editor-support/src/types.js b/packages/jest-editor-support/src/types.js
@@ -20,7 +20,6 @@ import type {ChildProcess} from 'child_process';
 import type ProjectWorkspace from './project_workspace';
 
 export type Options = {
-  coverage?: boolean,
   createProcess?: (
     workspace: ProjectWorkspace,
     args: Array<string>,