Throw Error When Using Nested It Specs (#4039)

* throw error when adding nested it specs * add comment * improve error message * Update Env.js
jestjs · Aug 24, 2017 · 82e6639 · 82e6639
1 parent fcf64d7
commit 82e6639
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/packages/jest-jasmine2/src/jasmine/Env.js b/packages/jest-jasmine2/src/jasmine/Env.js
@@ -388,6 +388,18 @@ module.exports = function(j$) {
       if (currentDeclarationSuite.markedPending) {
         spec.pend();
       }
+
+      // When a test is defined inside another, jasmine will not run it.
+      // This check throws an error to warn the user about the edge-case.
+      if (currentSpec !== null) {
+        throw new Error(
+          'Tests cannot be nested. Test `' +
+            spec.description +
+            '` cannot run because it is nested within `' +
+            currentSpec.description +
+            '`.',
+        );
+      }
       currentDeclarationSuite.addChild(spec);
       return spec;
     };