Do not hoist nested jest.mock calls, only add the getJestObj getter

jestjs · Feb 28, 2023 · 7ca29c5 · 7ca29c5
1 parent 6b9af46
commit 7ca29c5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/babel-plugin-jest-hoist/src/__tests__/__snapshots__/hoistPlugin.test.ts.snap b/packages/babel-plugin-jest-hoist/src/__tests__/__snapshots__/hoistPlugin.test.ts.snap
@@ -298,8 +298,8 @@ jest.mock('someModule', () => {
       ↓ ↓ ↓ ↓ ↓ ↓
 
 _getJestObj().mock('someModule', () => {
-  expect(_getJestObj().mock('someNode')).toBe(1);
   require('x');
+  expect(_getJestObj().mock('someNode')).toBe(1);
 });
 function _getJestObj() {
   const {jest} = require('@jest/globals');

diff --git a/packages/babel-plugin-jest-hoist/src/index.ts b/packages/babel-plugin-jest-hoist/src/index.ts
@@ -288,7 +288,10 @@ const extractJestObjExprIfHoistable = (expr: NodePath): JestObjInfo | null => {
   // Important: Call the function check last
   // It might throw an error to display to the user,
   // which should only happen if we're already sure it's a call on the Jest object.
-  const functionIsHoistable = FUNCTIONS[propertyName]?.(args) ?? false;
+  const functionIsHoistable =
+    expr.parentPath.isExpressionStatement() &&
+    (FUNCTIONS[propertyName]?.(args) ?? false);
+
   let functionHasHoistableScope = functionIsHoistable;
   for (
     let path: NodePath<Node> | null = expr;