Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
SimenB authored Nov 24, 2021
1 parent bde3639 commit 555d41f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 14 deletions.
2 changes: 1 addition & 1 deletion packages/jest-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"jest-validate": "^27.3.1",
"micromatch": "^4.0.4",
"pretty-format": "^27.3.1",
"slash": "^4.0.0"
"slash": "^3.0.0"
},
"devDependencies": {
"@types/babel__core": "^7.0.4",
Expand Down
6 changes: 1 addition & 5 deletions packages/jest-config/src/resolveConfigPath.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import * as path from 'path';
import chalk = require('chalk');
import * as fs from 'graceful-fs';
import slashModule = require('slash');
import slash = require('slash');
import type {Config} from '@jest/types';
import {
JEST_CONFIG_BASE_NAME,
Expand All @@ -21,10 +21,6 @@ const isFile = (filePath: Config.Path) =>

const getConfigFilename = (ext: string) => JEST_CONFIG_BASE_NAME + ext;

// Fix incorrect TypeScript definition for `slash` package.
const slash: typeof slashModule.default =
slashModule as unknown as typeof slashModule.default;

export default (
pathToResolve: Config.Path,
cwd: Config.Path,
Expand Down
9 changes: 1 addition & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -12658,7 +12658,7 @@ fsevents@^1.2.7:
micromatch: ^4.0.4
pretty-format: ^27.3.1
semver: ^7.3.5
slash: ^4.0.0
slash: ^3.0.0
strip-ansi: ^6.0.0
ts-node: ^9.0.0
typescript: ^4.0.3
Expand Down Expand Up @@ -19642,13 +19642,6 @@ [email protected]:
languageName: node
linkType: hard

"slash@npm:^4.0.0":
version: 4.0.0
resolution: "slash@npm:4.0.0"
checksum: 714b10473dd5efce5ebaad47c74d69201baf7715fa58e8049d3d2716d9da25a9571bfd3ecc50c3b7f4165948e2d8d5a1aa7faeaeca4891ee71a2fbd408268091
languageName: node
linkType: hard

"slice-ansi@npm:^2.0.0":
version: 2.1.0
resolution: "slice-ansi@npm:2.1.0"
Expand Down

0 comments on commit 555d41f

Please sign in to comment.