set exitcode to 1 if tests log after teardown

jestjs · Oct 28, 2020 · 34ea4c1 · 34ea4c1
1 parent 132e3d1
commit 34ea4c1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/e2e/__tests__/consoleAfterTeardown.test.ts b/e2e/__tests__/consoleAfterTeardown.test.ts
@@ -13,7 +13,7 @@ test('console printing', () => {
   const {stderr, exitCode} = runJest('console-after-teardown');
   const {rest} = extractSummary(stderr);
 
-  expect(exitCode).toBe(0);
+  expect(exitCode).toBe(1);
 
   const withoutTrace = rest.split('\n').slice(0, -3).join('\n');
 

diff --git a/packages/jest-runner/src/runTest.ts b/packages/jest-runner/src/runTest.ts
@@ -61,8 +61,7 @@ function freezeConsole(
     );
 
     process.stderr.write('\n' + formattedError + '\n');
-    // TODO: set exit code in Jest 25
-    // process.exitCode = 1;
+    process.exitCode = 1;
   };
 }