Long run monitoring #904
Merged
Long run monitoring #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3025010421
💛 - Coveralls |
legend1202
pushed a commit
to legend1202/vscode-jest
that referenced
this pull request
Jun 18, 2023
* enhance reporters * adding long run monitoring * fix eslint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
One of the most common complaints is the extension seems to consume lots of resources. Given the extension is just a thin wrapper over jest, many of those issues most likely could be addressed by changing the settings, such as
jest.autoRun. This PR is to add proactive monitoring to inform users when the seemingly long run (defined by the new settingjest.monitorLongRun) is detected, and provide info to help users address it.Change outline
jest.monitorLongRunto control the threshold of the long-run detection.LongRunMonitorinRunTestListenerto monitor runs that exceed the configured threshold (jest.monitorLongRun)Follow-up
Right now the default setting of the monitor is 60000ms, i.e. 1 minute. Not sure if this is sufficient or becoming too annoying for some users... Let's observe the pre-release response.