Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support the new jestCommandLine setting #644

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

connectdotz
Copy link
Collaborator

This PR mainly to kick start the jestCommandLine transition in vscode-jest per jest-community/jest-editor-support#44 and pave the way for setup wizard.

To summarize:

  • adding the new setting "jest.jestCommandLine" that should eventually replace "jest.pathToJest" and "jest.pathToConfig".
  • marking "jest.pathToJest" and "jest.pathToConfig" to be deprecated
  • modify JestExt and extensionManager of consider jestCommandLine over the legacy settings so it is completely backward compatible.

Note:

  • unlike pathToJest, there is no "guessing" logic or default value for jestCommandLine.
  • I did not change the README yet, plan to update it in the wizard PR later.

@coveralls
Copy link

coveralls commented Jan 4, 2021

Pull Request Test Coverage Report for Build 868

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 89.418%

Totals Coverage Status
Change from base Build 863: 0.2%
Covered Lines: 1085
Relevant Lines: 1196

💛 - Coveralls

@connectdotz
Copy link
Collaborator Author

@seanpoulter and @stephtr,

looks like you guys are busy, if you guys have other reviewer suggestion, please let me know, otherwise I plan to merge it to alpha so we can have more people playing with it.

@stephtr
Copy link
Member

stephtr commented Jan 13, 2021

Sorry for my unresponsiveness. I'll try to do it today or tomorrow evening.

Copy link
Member

@stephtr stephtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point one should also update the GitHub issue template to reflect the change.
Besides that: Looks good to me. Also checked jest-editor-support to ensure that there won't be any surprises, for example on Windows 😉

@connectdotz connectdotz merged commit c8ba11e into jest-community:master Jan 17, 2021
@connectdotz connectdotz deleted the jestCommandLine branch January 17, 2021 22:04
@seanpoulter
Copy link
Member

My apologies @connectdotz, I no longer have the free time or the opportunity to use the extension. Let me know if there's anything else I should do to bow out for now.

@connectdotz
Copy link
Collaborator Author

@seanpoulter I know life is unpredictable and I thank you on behave of the whole community for the time and effort you have put in for this package. I hope from time to time when you have a bit of free time that you can still chime in with your thoughts...

@stephtr so glad to see you back! Hope you will have a bit more time in 2021 as we are really trying to wrap up v4. I am working on 2 PRs about the parameterized tests and setup wizard, would love to have you take a look and test out on the windows platform...

We should probably expand our reviewer circle so in case we are busy this package can still move forward... I will try to get more involved, feel free to suggest reviewers next time if you can't do it yourself...

@connectdotz connectdotz mentioned this pull request Jan 27, 2021
15 tasks
@stephtr
Copy link
Member

stephtr commented Jan 30, 2021

so glad to see you back! Hope you will have a bit more time in 2021 as we are really trying to wrap up v4. I am working on 2 PRs about the parameterized tests and setup wizard, would love to have you take a look and test out on the windows platform...

Unfortunately no, apart from work, I have hardly any time available. I'm nevertheless trying to squeeze in some time for this project, sometimes more and sometimes less successful.

legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants