-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support the new jestCommandLine setting #644
support the new jestCommandLine setting #644
Conversation
Pull Request Test Coverage Report for Build 868
💛 - Coveralls |
@seanpoulter and @stephtr, looks like you guys are busy, if you guys have other reviewer suggestion, please let me know, otherwise I plan to merge it to alpha so we can have more people playing with it. |
Sorry for my unresponsiveness. I'll try to do it today or tomorrow evening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point one should also update the GitHub issue template to reflect the change.
Besides that: Looks good to me. Also checked jest-editor-support
to ensure that there won't be any surprises, for example on Windows 😉
My apologies @connectdotz, I no longer have the free time or the opportunity to use the extension. Let me know if there's anything else I should do to bow out for now. |
@seanpoulter I know life is unpredictable and I thank you on behave of the whole community for the time and effort you have put in for this package. I hope from time to time when you have a bit of free time that you can still chime in with your thoughts... @stephtr so glad to see you back! Hope you will have a bit more time in 2021 as we are really trying to wrap up v4. I am working on 2 PRs about the parameterized tests and setup wizard, would love to have you take a look and test out on the windows platform... We should probably expand our reviewer circle so in case we are busy this package can still move forward... I will try to get more involved, feel free to suggest reviewers next time if you can't do it yourself... |
Unfortunately no, apart from work, I have hardly any time available. I'm nevertheless trying to squeeze in some time for this project, sometimes more and sometimes less successful. |
This PR mainly to kick start the jestCommandLine transition in
vscode-jest
per jest-community/jest-editor-support#44 and pave the way for setup wizard.To summarize:
JestExt
andextensionManager
of considerjestCommandLine
over the legacy settings so it is completely backward compatible.Note:
pathToJest
, there is no "guessing" logic or default value forjestCommandLine
.