Fix cursor in terminal app #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Oct 5, 2018
thymikee
approved these changes
Oct 5, 2018
|
@rogeliog is this ready? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20
This PR fixes an issue with terminals like Terminal.app in MacOS... We've seen similar issues in the past, when the typeahead was inside Jest core (i.e. jestjs/jest#3392 and jestjs/jest#2594) but I still want to further investigate the issue.
By reseting the cursor to the position
x=0of the current line(the leftmost position) we ensure the text starts in the correct position. Although this fixes it, I still want to have a better understanding of why this regression happened and how to prevent similar issues in the future.This gif shows be behavior in master vs this PR
