chore: use jest-serializer-ansi-escapes
#161
Conversation
| [MOCK - cursorSavePosition] | ||
| [MOCK - cursorLeft] | ||
| <dim>›</> <dim>src/</></>fi</><dim>le-2.js</> | ||
| <moveCursorToRow6Column14> |
There was a problem hiding this comment.
In ansi-escapes position is zero based, but in vanilla escapes it is 1 base and also row argument goes first. That’s why [MOCK - cursorTo(13, 5)] becomes <moveCursorToRow6Column14>
| @@ -1,34 +1,9 @@ | |||
| import { KEYS } from 'jest-watcher'; | |||
| import type { Config } from '@jest/types'; | |||
| import { jest } from '@jest/globals'; | |||
There was a problem hiding this comment.
Import is not used anymore.
| @@ -4,36 +4,11 @@ import { | |||
| JestHookEmitter, | |||
| UpdateConfigCallback, | |||
| } from 'jest-watcher'; | |||
| import stripAnsi from 'strip-ansi'; | |||
There was a problem hiding this comment.
The dependency is still used in code. So I left it in package.json.
…izer-ansi-escapes
|
@mrazauskas thanks! Could you add support for node 12 in engines? EDIT: never mind, just dropped it |
…izer-ansi-escapes
|
Seems there's a v2 (#163), should we update? |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks! I will send a PR for v2 bit later. It had improved serialization of reset sequences. I was sticking with v1 here to keep diffs smaller (; |
Similar to jestjs/jest#12935
jest-serializer-ansi-escapesis a replacement for Jest’s internalpretty-format/ConvertAnsiplugin. It serializes cursor control as well as color and style ANSI escapes.Currently in tests of
jest-watch-typeaheadcursor control escapes are snapped by mockingansi-escapes. This works, but as you can see in the snapshotsjest-serializer-ansi-escapesplugin is catching few more missing sequences.Other difference – the mocking solution depends on
ansi-escapes; the plugin is simply serialising vanilla sequences. Hence, using it makes easier to replaceansi-escapesin the future.