feat: create no-conditional-in-test rule
#1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
replace-no-if
branch
4 times, most recently
from
468c0c0 to
86fb738
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2022
# [26.1.0-next.1](v26.0.0...v26.1.0-next.1) (2022-02-06) ### Features * create `no-conditional-in-test` rule ([#1027](#1027)) ([004ddc5](004ddc5))
|
🎉 This PR is included in version 26.1.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
G-Rath
added a commit
that referenced
this pull request
Feb 6, 2022
G-Rath
pushed a commit
that referenced
this pull request
Feb 6, 2022
# [26.1.0-next.1](v26.0.0...v26.1.0-next.1) (2022-02-06) ### Features * create `no-conditional-in-test` rule ([#1027](#1027)) ([004ddc5](004ddc5))
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2022
# [26.1.0](v26.0.0...v26.1.0) (2022-02-06) ### Features * create `no-conditional-in-test` rule ([#1027](#1027)) ([d551850](d551850)) * create `prefer-snapshot-hint` rule ([#1012](#1012)) ([d854723](d854723)) * deprecate `no-if` in favor of `no-conditional-in-test` ([#1049](#1049)) ([35f32cc](35f32cc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replace is meant to replace
no-if: in addition to making the name and documentation consistent (since the rule supports more than justifstatements), it greatly simplifies it by reporting any condition in a test state.If developers have a good reason for a condition within a test, then they can disable the rule with an inline disable.
This fixes #1026
I'll do a follow-up PR deprecating
no-if, so that there's a changelog entry for visibility.