Skip to content

Commit

Permalink
fix: stop testing ESLint 5 (#893)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Drop support for ESLint 5
  • Loading branch information
SimenB authored Sep 13, 2021
1 parent 13c041a commit 0ee1f84
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
fail-fast: false
matrix:
node-version: [12.x, 14.x, 16.x]
eslint-version: [5, 6, 7]
eslint-version: [6, 7]
runs-on: ubuntu-latest

steps:
Expand All @@ -83,12 +83,11 @@ jobs:
yarn
yarn add --dev eslint@${{ matrix.eslint-version }}
- name: run tests
# only collect coverage on eslint versions that support the suggestions api
run: yarn test --coverage ${{ matrix.eslint-version >= 6 }}
run: yarn test --coverage
env:
CI: true
- uses: codecov/[email protected]
if: ${{ matrix.eslint-version >= 6 }}
if: always()
test-os:
name: Test on ${{ matrix.os }} using Node.js LTS
needs: prepare-yarn-cache
Expand Down

0 comments on commit 0ee1f84

Please sign in to comment.