fix(prefer-spy-on): fix Cannot read property 'type' of undefined (#199)

Fixes #198
jest-community · Nov 4, 2018 · 02cd21a · 02cd21a
1 parent ae7aee9
commit 02cd21a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/rules/__tests__/prefer-spy-on.test.js b/rules/__tests__/prefer-spy-on.test.js
@@ -13,6 +13,7 @@ ruleTester.run('prefer-spy-on', rule, {
   valid: [
     'Date.now = () => 10',
     'window.fetch = jest.fn',
+    'Date.now = fn()',
     'obj.mock = jest.something()',
     'const mock = jest.fn()',
     'mock = jest.fn()',

diff --git a/rules/prefer-spy-on.js b/rules/prefer-spy-on.js
@@ -4,7 +4,10 @@ const getDocsUrl = require('./util').getDocsUrl;
 const getNodeName = require('./util').getNodeName;
 
 const getJestFnCall = node => {
-  if (node.type !== 'CallExpression' && node.type !== 'MemberExpression') {
+  if (
+    (node.type !== 'CallExpression' && node.type !== 'MemberExpression') ||
+    (node.callee && node.callee.type !== 'MemberExpression')
+  ) {
     return null;
   }