Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Button onClick={does not work}... #7

Closed
hipertracker opened this issue Jan 4, 2015 · 3 comments
Closed

<Button onClick={does not work}... #7

hipertracker opened this issue Jan 4, 2015 · 3 comments
Labels

Comments

@hipertracker
Copy link

How to pass own handler to onClick event inside in Button component? The way it is implemented shows that I cannot use my handler unless I extend somehow Button class to provide my own onClick method. When I remove the line "onClick={this.onClick}" from elements/button.jsx than I am free to use my own handlers. The unit test fore button.jsx is wrong. It does not test anything for onClick. The passed handler is never excuted.

@jessy1092 jessy1092 added bug and removed bug labels Jan 4, 2015
@jessy1092
Copy link
Owner

Sorry, my fault. You're right. The onClick function should be on <Unit> component test.
It didn't trigger on element.

@jessy1092
Copy link
Owner

v0.2.1: some elements onClick function not work.

  • Segment, Label, Icon, Header, Flag, Button

jessy1092 added a commit that referenced this issue Jan 4, 2015
jessy1092 added a commit that referenced this issue Jan 4, 2015
- Fix the onClick function Bug. issue #7
  + Remove onClick Function Test on elements.
    - Segment, Label, Icon, Header, Flag, Button
- Add Collections and Views Test Function.
@jessy1092
Copy link
Owner

@hipertracker Thanks. It should be working on v0.2.2 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants