WIP: Allow setting and reseting bool values via standard arguments #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the developer to allow setting boolean values to `false`. There already was a piece of code which indirectly allowed this, but default could never be true for bools due to jessevdk#159. With this patch, a new setting `disable-type` is introduced on boolean options. If unset, the bool variables act as before. However, if set, the user can set (and reset) the bool varaible to either `true` or `false`. The setting has three possible values: `value`. `no` and `enable-disable`. When the setting is enabled, bool values will behave as follows: | *`disable-value`* | Syntax | | `value` | `--bool[=true|false]` | | `no` | `--[no-]bool` | | `enable-disable` | `--[enable|disable]-bool` | This allows for use cases such as: ```sh alias program='program --debug` program --no-debug ``` or ```sh ./program --enable-raytracing --disable-antialiasing ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm sharing this work-in-progress code to see if this is something you would be willing to merge. So far, most of the code works, but I would need some help with:
I've also deprecated
AllowBoolValuessince this feature replaces it. In my opinion, this was not really a good place to implement it in the first place. However, I would like to open a discussion about this as well.Your response is appreciated. Thank you for the great work!
This commit enables the developer to allow setting boolean values to
false. There already was a piece of code which indirectly allowed this, but default could never be true for bools due to #159.With this patch, a new setting
disable-typeis introduced on boolean options. If unset, the bool variables act as before. However, if set, the user can set (and reset) the bool variable to eithertrueorfalse.The setting has three possible values:
value.noandenable-disable.When the setting is enabled, bool values will behave as follows:
|
disable-value| Syntax ||
value|--bool[=true|false]||
no|--[no-]bool||
enable-disable|--[enable|disable]-bool|This allows for use cases such as:
or