Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SOURCE_DATE_EPOCH for reproducible builds #285

Merged
merged 2 commits into from
Dec 21, 2018

Conversation

mnm678
Copy link
Contributor

@mnm678 mnm678 commented Oct 29, 2018

While working on the reproducible builds project, I noticed that projects using go-flags cannot build reproducibly because of the timestamp in the generated man pages.

This patch makes the output consistent across kernel versions by using the SOURCE_DATE_EPOCH environment variable to allow for a consistent timestamp.

Copy link
Owner

@jessevdk jessevdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jessevdk jessevdk merged commit a1c83c9 into jessevdk:master Dec 21, 2018
anthonyfok added a commit to anthonyfok/go-flags that referenced this pull request Dec 2, 2021
This stems from of Marina Moore’s (@mnm678) excellent work
on adding SOURCE_DATE_EPOCH for reproducible builds in PR jessevdk#285,
and has been extended by Jelmer Vernooij (@jelmer) such that
TestMan in help_test.go would not fail when SOURCE_DATE_EPOCH
is set to a date different from today.

Reference:
* https://salsa.debian.org/go-team/packages/golang-go-flags/-/merge_requests/1
* https://salsa.debian.org/go-team/packages/golang-go-flags/-/commit/3f11c5378d8d3778fbd6b249d6dd26e4785fd7ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants