Add filepath as an equivalent to filename which completes into subdirs. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectories. I have some cases where this was the behaviour I wanted; obviously users can implement this themselves but it seems pretty generally useful (probably as much so as Filename?).
jessevdk
requested changes
Mar 31, 2018
|
Yup, makes sense! |
jessevdk
reviewed
Sep 23, 2018
completion.go
Outdated
| @@ -62,6 +63,11 @@ func completionsWithoutDescriptions(items []string) []Completion { | |||
| // prefix. | |||
| func (f *Filename) Complete(match string) []Completion { | |||
| ret, _ := filepath.Glob(match + "*") | |||
| if len(ret) == 1 { | |||
| if info, err := os.Stat(ret[0]); err == nil && info.IsDir() { | |||
| ret, _ = filepath.Glob(ret[0] + "/*") | |||
There was a problem hiding this comment.
What if there is only one file that is a dir here too? I think this should just recurse? Since this has been waiting so long, I'll make the change. Thanks for contributing!!
|
Sorry this all took so long, I've been thinking a bit more about it though and I think we should do what bash does instead. Meaning, if it's a single directory, it should complete to |
|
Merged through here #272, let me know if this doesn't really solve your problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some cases where this was the behaviour I wanted; obviously users can implement this themselves but it seems pretty generally useful (probably as much so as Filename?).