Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Delegate] implement additional selection / multi-selection + editing APIs? #94

Open
4 of 7 tasks
jessesquires opened this issue May 24, 2024 · 6 comments
Open
4 of 7 tasks

Comments

@jessesquires
Copy link
Owner

jessesquires commented May 24, 2024

Selection

Selection docs: https://developer.apple.com/documentation/uikit/uicollectionviewdelegate#1656555

Single Selection APIs

  • collectionView(_:shouldSelectItemAt:)
  • collectionView(_:didSelectItemAt:) - CellEventCoordinator
  • collectionView(_:shouldDeselectItemAt:)
  • collectionView(_:didDeselectItemAt:) - CellEventCoordinator

Multi-selection APIs

  • collectionView(_:shouldBeginMultipleSelectionInteractionAt:)
  • collectionView(_:didBeginMultipleSelectionInteractionAt:) - CellEventCoordinator?
  • collectionViewDidEndMultipleSelectionInteraction(_:)

Editing

Edit docs: https://developer.apple.com/documentation/uikit/uicollectionviewdelegate#3618659

@jessesquires jessesquires changed the title [Delegate] implement additional selection / multi-selection APIs [Delegate] implement additional selection / multi-selection + editing APIs? May 24, 2024
@nuomi1
Copy link
Collaborator

nuomi1 commented Aug 28, 2024

Managing the selected cells

  • collectionView(_:shouldSelectItemAt:)
  • collectionView(_:didSelectItemAt:) - CellEventCoordinator
  • collectionView(_:shouldDeselectItemAt:)
  • collectionView(_:didDeselectItemAt:) - CellEventCoordinator?
  • collectionView(_:shouldBeginMultipleSelectionInteractionAt:)
  • collectionView(_:didBeginMultipleSelectionInteractionAt:) - CellEventCoordinator?
  • collectionViewDidEndMultipleSelectionInteraction(_:)

@jessesquires
Copy link
Owner Author

As far as PRs go, let's group single selection into 1 PR and multi-selection into another.

We should probably also exercise this functionality in the example app.

@jessesquires
Copy link
Owner Author

Also, I'd say this task (especially multi-selection) is lower priority than others.

@nuomi1
Copy link
Collaborator

nuomi1 commented Aug 28, 2024

As far as PRs go, let's group single selection into 1 PR and multi-selection into another.

That's what I meant. 😁

@nuomi1
Copy link
Collaborator

nuomi1 commented Aug 28, 2024

Also, I'd say this task (especially multi-selection) is lower priority than others.

Which task should I begin to start?

@jessesquires
Copy link
Owner Author

jessesquires commented Sep 2, 2024

Which task should I begin to start?

Sorry for the delay @nuomi1 ! I've started a discussion thread that we can use for this. 😄

#129

jessesquires pushed a commit that referenced this issue Oct 2, 2024
Issue #94

Add `shouldSelect`, `shouldDeselect`, `didDeselect()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants