This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
Refactor JSQMessageBubbleImageFactory to allow custom images #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2014 09:27
The factory is now instantiated, rather than used as a set of static methods. The default init function creates a factory which behaves exactly like the previous version. The two-parameter init function takes a custom image and user-defined strechable regions. Two new unit tests cover the custom image constructor
|
Thanks @walsh2000 ! At a glance looks great, I'll have more feedback later today/tonight. 👍 Nice work. |
|
Thanks again @walsh2000 - going to go ahead and merge and make some changes myself in the interest of time as I work on this tonight. 👍 |
jessesquires
added a commit
that referenced
this pull request
Oct 10, 2014
Refactor JSQMessageBubbleImageFactory to allow custom images
jessesquires
added a commit
that referenced
this pull request
Oct 10, 2014
This was referenced Oct 10, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jessesquires
Implemented the refactor using your feedback, and even added two unit tests to exercise the custom image flow.
I wasn't sure if you wanted the -[init] to appear in the header, but since that will be how 90% of everyone uses the factory, I decided to add it.