Fix with calulation of content offset; #1743
Conversation
Current coverage is 60.92%@@ develop #1743 diff @@
==========================================
Files 62 62
Lines 2224 2226 +2
Methods 612 612
Messages 0 0
Branches 134 134
==========================================
Hits 1356 1356
- Misses 793 795 +2
Partials 75 75
|
| animated:animated]; | ||
|
|
||
| CGFloat contentWindowHeight = collectionViewHeight - self.collectionView.contentInset.top - self.collectionView.contentInset.bottom; | ||
| CGFloat offsetHeight = MAX(0.f, collectionViewContentHeight - contentWindowHeight) - self.collectionView.contentInset.top; |
There was a problem hiding this comment.
why are we subtracting contentInset.top twice?
There was a problem hiding this comment.
Not exactly twice, only if content passed visible portion of scrolling view.
in contentWindowHeight it subtracting for get actual value of visible height of scroll view,
second time, in offsetHeight, it's subtracted as part of contentOffset - to get correct offset value
|
thanks @alexeyhippie ! a couple of questions for you |
|
👍 i'll need to test this on develop and then we can merge if all is good |
|
What is the status of this fix ? |
|
Hello everyone! I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details: http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/ Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊 Thanks for understanding, |
Pull request checklist
This fixes issue #256 .
What's in this pull request?
Fix with calulation of content offset;