Add cleaner dubious ownership error #3881
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Map dubious ownership error to user-friendly message - Add i18n entry for UnsafeOrNetworkDirectoryError - Capture dubious ownership error in repo_paths Signed-off-by: Kapparina <[email protected]>
|
@stefanhaller @jesseduffield Please review. |
jesseduffield
requested changes
Jan 9, 2025
| @@ -143,6 +143,10 @@ func callGitRevParseWithDir( | |||
| gitCmd := cmd.New(gitRevParse.ToArgv()).DontLog() | |||
| res, err := gitCmd.RunWithOutput() | |||
| if err != nil { | |||
| if strings.Contains(err.Error(), "fatal: detected dubious ownership in repository") { | |||
| err = errors.New("fatal: detected dubious ownership in repository") | |||
There was a problem hiding this comment.
Is it actually the case that the error sometimes contains more than just this string? If so I'd define this string in a constant to be also used in app/errors.go so that it's clear what the connection is.
| Whilst there is a solution/workaround, please understand the relevant risks and purpose of this warning! | ||
| See 'https://github.com/git/git/commit/8959555cee7ec045958f9b6dd62e541affb7e7d9' for background information on said risks | ||
|
|
||
| This error is unrelated to lazygit |
There was a problem hiding this comment.
Suggested change
| This error is unrelated to lazygit | |
| This error is unrelated to lazygit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves An error occurred! -- Detected dubious ownership in repository #3303, resolves "failed: fatal: detected dubious ownership in repository" when running lazygit on a newly initialized repository on a external drive #3757
Whilst the above issues expect lazygit to prompt the user to prompt whether it should modify their global Git configuration, I believe it is more pertinent that the user instead inform themselves of what's actually going on.
This PR adds a new known error message covering "dubious ownership". Rather than panicking when Git throws such an error, the below error message will be displayed:
Whilst I'm not against contributing to the implementation of the expected behaviour in the aforementioned issues, I think informing users of the risks involved is a necessary starting point.
go generate ./...)