Add "networks" panel under "volumes" #424
Conversation
|
Thanks for making this! Sorry I've been super busy lately but I'll give this a review when I get the chance |
| // we're sorting these networks based on whether they have labels defined, | ||
| // because those are the ones you typically care about. | ||
| // Within that, we also sort them alphabetically | ||
| Sort: func(a *commands.Network, b *commands.Network) bool { |
There was a problem hiding this comment.
I assume we do something similar with another panel, but for networks is it actually true that we care more about labels than names? I suspect not
There was a problem hiding this comment.
Yes, it's exactly like volumes sorting, which fits to networks, i guess.
So, may be should we sort networks by driver at first and then by names?
There was a problem hiding this comment.
I'm thinking we just sort by name: I doubt the typical user has many networks configured anyway
|
Tested locally and it works like a charm. Looks like you need to regenerate cheatsheets though (using |
|
Thanks for making this @tony-sol ! |
|
Should we be seeing this in the |
Just a little improvement with adding "Networks" panel under "Volumes" one