#287 Display hotkeys to detach from the container #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/gui/containers_panel.go
Outdated
| @@ -409,7 +409,7 @@ func (gui *Gui) handleContainerAttach(g *gocui.Gui, v *gocui.View) error { | |||
| return gui.createErrorPanel(err.Error()) | |||
| } | |||
|
|
|||
| return gui.runSubprocess(c) | |||
| return gui.runSubprocessWithMessage(c, "By default, to detach from the container press ctrl-p then ctrl-q") | |||
There was a problem hiding this comment.
Can we internationalise this text?
Fix the linting again
|
Thanks, @jesseduffield for taking the time to review, i have internationalised the text as requested Please review |
|
@glendsoza I've resolved conflicts but I can't push to your branch so I've recreated this in a separate PR: #465 |
|
PR is great btw! I'll add it in the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.