Various improvements #372
Merged
Various improvements #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in front of a side view
jesseduffield
changed the title
jesseduffield
commented
Oct 10, 2022
| @@ -15,25 +15,27 @@ import ( | |||
|
|
|||
| func (gui *Gui) wrappedConfirmationFunction(function func(*gocui.Gui, *gocui.View) error) func(*gocui.Gui, *gocui.View) error { | |||
| return func(g *gocui.Gui, v *gocui.View) error { | |||
| if err := gui.closeConfirmationPrompt(); err != nil { | |||
There was a problem hiding this comment.
following lazygit's lead by always returning focus BEFORE running a handler, to prevent all kinds of shenanigans
remove redundant g argument
Closed
jesseduffield
changed the title
This was referenced Oct 10, 2022
Closed
This was referenced Oct 10, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
Given these ports can be long, we needed a way to increase the size of the current window so that we can see the whole port if necessary. I've split out a lazycore repo for shared functionality between lazygit and lazydocker and I've moved the boxlayout package into that.
I've also fixed up some focus issues I noticed along the way.
If the IP of the port is 0.0.0.0 we'll omit that, otherwise we'll show it