Skip to content

Commit

Permalink
helix/rev3_4rows, helix/rev3_5rows: Fix build with converters (qmk#21608
Browse files Browse the repository at this point in the history
)

The code for Helix rev3 boards could not be built with, e.g.,
`CONVERT_TO=rp2040_ce` due to invalid `#include <stdio.h>` in the
keyboard level `config.h` (apparently the AVR version of that file
contains guards against usage in assembly code, which was hiding the
bug).  Move `#include <stdio.h>` to the C sources which need it.
  • Loading branch information
sigprof authored and jesperhellberg committed Jul 30, 2023
1 parent b42171c commit d8cdea7
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 4 deletions.
2 changes: 0 additions & 2 deletions keyboards/helix/rev3_4rows/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#pragma once

#include <stdio.h>

/* key matrix size */
#define MATRIX_ROWS 8
#define MATRIX_COLS 7
Expand Down
2 changes: 2 additions & 0 deletions keyboards/helix/rev3_4rows/keymaps/default/oled_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

#include QMK_KEYBOARD_H

#include <stdio.h>

// Defines names for use in layer keycodes and the keymap
enum layer_names {
_QWERTY = 0,
Expand Down
2 changes: 2 additions & 0 deletions keyboards/helix/rev3_4rows/keymaps/via/oled_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

#include QMK_KEYBOARD_H

#include <stdio.h>

// Defines names for use in layer keycodes and the keymap
enum layer_names {
_QWERTY = 0,
Expand Down
2 changes: 0 additions & 2 deletions keyboards/helix/rev3_5rows/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#pragma once

#include <stdio.h>

/* key matrix size */
#define MATRIX_ROWS 10
#define MATRIX_COLS 7
Expand Down
2 changes: 2 additions & 0 deletions keyboards/helix/rev3_5rows/keymaps/default/oled_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

#include QMK_KEYBOARD_H

#include <stdio.h>

// Defines names for use in layer keycodes and the keymap
enum layer_names {
_QWERTY = 0,
Expand Down
2 changes: 2 additions & 0 deletions keyboards/helix/rev3_5rows/keymaps/via/oled_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

#include QMK_KEYBOARD_H

#include <stdio.h>

// Defines names for use in layer keycodes and the keymap
enum layer_names {
_QWERTY = 0,
Expand Down

0 comments on commit d8cdea7

Please sign in to comment.