Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First commit, add cache option to zeep and create a basic test case w… #141

Conversation

TristanFAURE
Copy link
Contributor

@TristanFAURE TristanFAURE commented Oct 6, 2023

#140
First commit, add cache option to zeep and create a basic test case with no properties

also add skipped status

Work in Progress, only for a first status and first comments

@jesper-raemaekers
Copy link
Owner

Hi,

Just to let you know, the test runner in DevOps runs on Polarion 21r2 which has no tokens to sign in. I chedk and your tests work fine on it when using the password, so please use that in your final commit.

I'm curious.. does the cache improve performance a lot?

Thanks for helping out!

@TristanFAURE
Copy link
Contributor Author

TristanFAURE commented Oct 10, 2023

Hi

Hi,

Just to let you know, the test runner in DevOps runs on Polarion 21r2 which has no tokens to sign in. I chedk and your tests work fine on it when using the password, so please use that in your final commit.

ok no problem, thanks for the information ! By the way with the token authentication there is a performance issue if no user is provided (data cannot retrieved from services dict). So in my tests I put "_" in username or something like that

I'm curious.. does the cache improve performance a lot?

Thanks for helping out!

It should I wanted to ask somebody to test as I have few existing metrics ... I also need somebody to test on a windows environment. The cache is used to store wsdl metadata (as mentioned here: https://docs.python-zeep.org/en/master/transport.html)

Another change that should improve performance is

if self.transport is None:

because Session was created a lot of time

By the way do you have feedbacks about our suggestion to add traceability links thanks to properties ?

not yet using property inside sys out values
had some issues while getting traceabilty from a test case in my test
@TristanFAURE
Copy link
Contributor Author

I updated my test to use token or passwords, HTH

to make the algorithm easier to read and maintain I do not manage traceability between test cases, I'm not sure it is a real need WDYT @jesper-raemaekers or @LionnelC ?

Copy link
Contributor

@LionnelC LionnelC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not have many times to check deeper

polarion/polarion.py Outdated Show resolved Hide resolved
@TristanFAURE
Copy link
Contributor Author

TristanFAURE commented Oct 11, 2023

we will see the result of the tests, but in terms of features it is ok for #140

tell me if you need changes to accept the PR

@TristanFAURE
Copy link
Contributor Author

For the future I think we will add possiblity to create workitems from test suites we need kind of mapping information, but it will be another issue, so you can review this PR

@TristanFAURE
Copy link
Contributor Author

Hi,

Just to let you know, the test runner in DevOps runs on Polarion 21r2 which has no tokens to sign in. I chedk and your tests work fine on it when using the password, so please use that in your final commit.

I'm curious.. does the cache improve performance a lot?

Thanks for helping out!

And about the cache for a process with a duration of 38 sec with the cache it is now 30 sec

@TristanFAURE TristanFAURE requested a review from LionnelC October 17, 2023 18:55
@TristanFAURE
Copy link
Contributor Author

@LionnelC @jesper-raemaekers
who will perform the review ? please tell me if some changes are needed

@jesper-raemaekers jesper-raemaekers merged commit 7155a2a into jesper-raemaekers:main Oct 22, 2023
10 checks passed
@jesper-raemaekers
Copy link
Owner

@LionnelC @jesper-raemaekers who will perform the review ? please tell me if some changes are needed

Sorry, got to it now!

Hi,
Just to let you know, the test runner in DevOps runs on Polarion 21r2 which has no tokens to sign in. I chedk and your tests work fine on it when using the password, so please use that in your final commit.
I'm curious.. does the cache improve performance a lot?
Thanks for helping out!

And about the cache for a process with a duration of 38 sec with the cache it is now 30 sec

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants