Add custom dispatcher to every builtin object for consistency #4738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orkvi
force-pushed
the
builtin-weakset
branch
2 times, most recently
from
731e460 to
07ab121
Compare
|
What is the binary size effect of this change? Or runtime? In other words, what is the benefit? |
The only reason is consistency. (We would like to use custom dispatcher everywhere) |
orkvi
force-pushed
the
builtin-weakset
branch
3 times, most recently
from
0569326 to
3bb96a1
Compare
orkvi
force-pushed
the
builtin-weakset
branch
from
3bb96a1 to
6ffae3e
Compare
orkvi
force-pushed
the
builtin-weakset
branch
3 times, most recently
from
d323cf1 to
fcb0e84
Compare
JerryScript-DCO-1.0-Signed-off-by: Orkenyi Virag [email protected]
orkvi
force-pushed
the
builtin-weakset
branch
from
fcb0e84 to
5a4bf13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Orkenyi Virag [email protected]