Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl into link libraries for iotjs build. #1438

Closed
wants to merge 1 commit into from

Conversation

ziransun
Copy link

curl library is not automatically added while building
iotjs for rpi zero natively. This library is required
for http module.

IoT.js-DCO-1.0-Signed-off-by:Ziran Sun [email protected]

curl library is not automatically added while building
iotjs for rpi zero natively. This library is required
for http module.

IoT.js-DCO-1.0-Signed-off-by:Ziran Sun <[email protected]>
@glistening
Copy link
Contributor

glistening commented Jan 24, 2018

@ziransun curl is linked when it is necessary. (currently only when https is enabled). Please see https://github.com/Samsung/iotjs/blob/master/src/modules.json#L197.

@ziransun
Copy link
Author

@glistening With https module enabled in build, curl doesn't seem linked in for rpi zero w native build. For other systems I tried so far it is linked in as you described.

@glistening
Copy link
Contributor

@ziransun Do you mean your are building iotjs on raspberry pi zero target (i.e. not cross compilation)? Could you give us your build environment (os, compiler, build command), and logs?

@rzr
Copy link
Contributor

rzr commented Jan 26, 2018

I added https to full profile (#1400) used to build deb package,

I think it worked without changing the cmake file.

To create raspbian deb package for pi0,
you can double check on your host by runninng:

  docker build https://github.com/tizenteam/iotjs.git

More to come at:
#1389

@glistening
Copy link
Contributor

@rzr We don't support debian packaging and RPI zero officially. I cannot accept the global change for unsupported configuration.

About full.profile, please see @LaszloLango's comment #1400 (review) and mine #1400 (comment).

@rzr
Copy link
Contributor

rzr commented Jan 30, 2018

OK, for feedback now I think this item can be closed,

BTW I am wondering if there is any attempt for https module to support tizenrt (with a libcurl port?)

To be tracked at:
https://developer.artik.io/forums/t/where-do-the-header-files-exist/3064

@yichoi yichoi closed this Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants