Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty print test duration artifact #31

Merged
merged 4 commits into from
Nov 9, 2021

Conversation

vpipkt
Copy link
Contributor

@vpipkt vpipkt commented Aug 11, 2021

This will enable cleaner comparisons for duration artifacts stored in VCS.

@vpipkt
Copy link
Contributor Author

vpipkt commented Oct 12, 2021

Can we get a maintainer review of this PR? Any feedback on this?

@jerry-git jerry-git self-requested a review October 12, 2021 17:01
@jerry-git
Copy link
Owner

Sorry, seems that I haven't seen this before. Hmm, the CI (GHA) doesn't run for some reason 🤔

tests/test_plugin.py Outdated Show resolved Hide resolved
@vpipkt
Copy link
Contributor Author

vpipkt commented Oct 15, 2021

@jerry-git now we have the workflow awaiting approval, b/c this is the first PR I've opened on the repo. We appreciate your attention to this one!

@vpipkt
Copy link
Contributor Author

vpipkt commented Oct 18, 2021

Any ideas what is going wrong with the CI build? It is failing installing poetry... 😞

@jerry-git
Copy link
Owner

I updated the install-poetry action, pull the latest changes from master please 🙂

@vpipkt
Copy link
Contributor Author

vpipkt commented Oct 19, 2021

hmm now the workflow is awaiting approval again. @jerry-git thanks for dealing with all the noise here.

@vpipkt
Copy link
Contributor Author

vpipkt commented Oct 22, 2021

Looks like this one is ready to go

Copy link
Owner

@jerry-git jerry-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jerry-git jerry-git merged commit 8b5a89e into jerry-git:master Nov 9, 2021
@jerry-git
Copy link
Owner

Available in 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants