Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Upgrade to Fastify v3 #3

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Upgrade to Fastify v3 #3

merged 1 commit into from
Sep 23, 2021

Conversation

jeromemacias
Copy link
Owner

No description provided.

@jeromemacias jeromemacias force-pushed the fastify_v3 branch 4 times, most recently from f623f1d to cd48940 Compare March 22, 2021 22:26
@feriwecan
Copy link

Hi @jeromemacias. What's up with this PR? How come it's not completed?
I'll be honest I tried this plugin with fastify 3.4.1 and it was not working, and I'm just starting to realize this might not be compatible with 3.x. I assumed it is based on the Readme "Fastify 2.0.0 or greater". Can you confirm that it won't work with 3.x?
Thanks!

feriwecan added a commit to feriwecan/fastify-xray that referenced this pull request Sep 10, 2021
feriwecan added a commit to feriwecan/fastify-xray that referenced this pull request Sep 10, 2021
@jeromemacias jeromemacias merged commit 51a5832 into master Sep 23, 2021
@jeromemacias jeromemacias deleted the fastify_v3 branch September 23, 2021 20:40
@jeromemacias
Copy link
Owner Author

@feriwecan I confirm that it will not work with fastify v3, can you confirm that this PR (now the master) works with v3 please ? Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants