Auto show right sidebar when section is present #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@resslinger Could you review if these changes may introduce another backward compatibility, other than renaming the section name to use snake case as all the other section names? |
|
@dfsmania I will check this. |
|
@resslinger Thanks, I don't believe there are many people using the right control sidebar. However, people using it will be required to update the section name when updating to a version with this PR included on it. |
|
@resslinger Wiki was updated for this PR, so you could merge this when finishing testing. However, do not make a new release still, since I'm currently working on solving another issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix #1140
Changes to auto show the right sidebar when section
right_sidebaris present on a blade file extending the layout.Also, the section was renamed from
right-sidebartoright_sidebarto keep consistency with other section names.Caution
When introducing this change on a new release, people using the
right-sidebarsection must rename it toright_sidebar. Also, if the views were published, they will require an update for the auto show feature to work.Checklist