Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to CURLOPT_UNRESTRICTED_AUTH = 0 #328

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Default to CURLOPT_UNRESTRICTED_AUTH = 0 #328

merged 1 commit into from
Jan 28, 2024

Conversation

tanho63
Copy link
Contributor

@tanho63 tanho63 commented Jan 18, 2024

Resolves #260 and perhaps r-lib/httr#626

@jeroen
Copy link
Owner

jeroen commented Jan 18, 2024

This is a breaking change, we probably have to mark it clearly in the news and bump the version. Sadly I don't remember why we set the default this way.

@tanho63
Copy link
Contributor Author

tanho63 commented Jan 18, 2024

@jeroen do you have a preference on what the next version number should be?

@jeroen jeroen merged commit 77501a0 into jeroen:master Jan 28, 2024
13 of 14 checks passed
@tanho63 tanho63 deleted the patch-1 branch January 28, 2024 15:52
@jeroen
Copy link
Owner

jeroen commented Mar 3, 2024

This has landed on CRAN in curl 5.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle uses insecure default (CURLOPT_UNRESTRICTED_AUTH = 1)
2 participants