Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Snoop Selection in Modify Tab #152

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Conversation

ricaun
Copy link
Contributor

@ricaun ricaun commented Apr 5, 2023

Summary of the Pull Request

Feature to enable/disable the Snoop Selection in Modify Tab in the setting.

What is this about:

  • Add enable/disable the Snoop Selection in Modify Tab in the setting.
  • Add Snoop Selection Command in the RevitLookup (Snoop section Command missing. #150)
  • Add Always Command Availability in the Dashboard command

Description:
I tried to follow your pattern to create the new setting, everything looks great except Application.UpdateModifyPanelVisibility is hardcoded in the SettingViewModel, I didn't know if I should create an interface in the ISettingsService and move the Application.UpdateModifyPanelVisibility to the SettingsService.

Quality Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@ricaun ricaun requested a review from Nice3point as a code owner April 5, 2023 13:08
@Nice3point
Copy link
Collaborator

Nice3point commented Apr 5, 2023

For now, let's hold off all PR for 2 weeks to gather feedback from all possible people and developers. We will come back to this theme later and make this option

@ricaun
Copy link
Contributor Author

ricaun commented Apr 5, 2023

For now, let's hold off all PR for 2 weeks to gather feedback from all possible people and developers. We will come back to this theme later and make this option

Ok

@Nice3point
Copy link
Collaborator

Ok

We will definitely add this, but first we need to decide in what way and how best for everyone

@ricaun
Copy link
Contributor Author

ricaun commented Apr 5, 2023

No worry, I gonna use my version and see if I find some other issue.

@Nice3point
Copy link
Collaborator

Nice3point commented Apr 5, 2023

@ricaun I have greatly simplified the code to add a button, please take a look. This also allowed to add hotkeys to it. If you want, you can check the source code to make the button always available on the ribbon without using a controller

fd54b8b

@ricaun
Copy link
Contributor Author

ricaun commented Apr 5, 2023

@ricaun I have greatly simplified the code to add a button, please take a look. This also allowed to add hotkeys to it. If you want, you can check the source code to make the button always available on the ribbon without using a controller

fd54b8b

Interesting, I never use this createPushButton.

Usually, I create the command in the normal way and move the Autodesk.Window.RibbonPanel or Autodesk.Window.RibbonItem using the m_RibbonItem as you did.

I don't know how you gonna synchronize the change without resetting Revit in your current code. Gonna be easier to create using the Revit way and copy the RibbonItem and put in the Modify.

@Nice3point Nice3point merged commit 7e3d967 into jeremytammik:dev Apr 6, 2023
@Nice3point
Copy link
Collaborator

I don't know how you gonna synchronize the change without resetting Revit in your current code. Gonna be easier to create using the Revit way and copy the RibbonItem and put in the Modify.

@ricaun I have added a live ribbon update now, update your fork 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants