Skip to content

Commit

Permalink
[Storage][File] use sourceConditions field name in public API
Browse files Browse the repository at this point in the history
for consistency with Blob.

In PR Azure#5672 we adopted the field names `conditions` and `sourceConditions`.
This change fixes the only place in File where `SourceModifiedAccessConditions`
is used in public API to be consistent.
  • Loading branch information
jeremymeng committed Oct 21, 2019
1 parent e0fdc87 commit 507895a
Showing 1 changed file with 16 additions and 3 deletions.
19 changes: 16 additions & 3 deletions sdk/storage/storage-file/src/FileClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,7 @@ export interface FileUploadRangeOptions extends CommonOptions {
* @export
* @interface FileUploadRangeFromURLOptions
*/
export interface FileUploadRangeFromURLOptions
extends FileUploadRangeFromURLOptionalParams,
CommonOptions {
export interface FileUploadRangeFromURLOptions extends CommonOptions {
/**
* An implementation of the `AbortSignalLike` interface to signal the request to cancel the operation.
* For example, use the @azure/abort-controller to create an `AbortSignal`.
Expand All @@ -231,6 +229,20 @@ export interface FileUploadRangeFromURLOptions
* @memberof FileUploadRangeFromURLOptions
*/
abortSignal?: AbortSignalLike;
/**
* The timeout parameter is expressed in seconds. For more information, see <a
* href="https://docs.microsoft.com/en-us/rest/api/storageservices/Setting-Timeouts-for-File-Service-Operations?redirectedfrom=MSDN">Setting
* Timeouts for File Service Operations.</a>
*/
timeoutInSeconds?: number;
/**
* Specify the crc64 calculated for the range of bytes that must be read from the copy source.
*/
sourceContentCrc64?: Uint8Array;
/**
* Additional parameters for the operation
*/
sourceConditions?: Models.SourceModifiedAccessConditions;
}

/**
Expand Down Expand Up @@ -1200,6 +1212,7 @@ export class FileClient extends StorageClient {
0,
{
abortSignal: options.abortSignal,
sourceModifiedAccessConditions: options.sourceConditions,
...options,
spanOptions
}
Expand Down

0 comments on commit 507895a

Please sign in to comment.