Nodal to Harmonic Basis #62
Conversation
|
Something looks strange here - you have a bunch of old commits that got squashed out of main |
|
@jedbrown, pls what can I try to clean this up. This keeps giving me copied commits, which I don't want |
|
Yeah @jeremylt. I need to clean this up. I have been trying to avoid this and it happened again. |
|
Do you know how to solve this problem or think you can figure it out? I see lots of conflicts here. What changes are intentional? Are they contained in a few commits you can cherry-pick or retain in a |
|
Only the last three commits are intentional |
jedbrown
force-pushed
the
ade/nodal-to-harmonic-basis
branch
from
112fe06 to
bc0075a
Compare
|
I reset your branch, with just the three commits cleanly applied on top of main. |
| plot(θ / π, eigenvalues ./ π, linewidth = 3) # Dispersion | ||
| plot!( | ||
| identity, | ||
| xlabel = "θ/π", | ||
| ylabel = "Eigenvalues", | ||
| label = "exact", | ||
| legend = :none, | ||
| color = :black, | ||
| title = "P=$P, collocate=$collocate, τ=$τ", | ||
| ) |
There was a problem hiding this comment.
Manual plotting shouldn't be part of these examples - only the Jupyter examples
There was a problem hiding this comment.
Yes, I am aware of that, it is only for tentative experimental purposes, it will be eventually removed.
| @@ -92,6 +92,7 @@ mutable struct Operator | |||
| multiplicity::AbstractArray{Float64} | |||
| rowmodemap::AbstractArray{Float64,2} | |||
| columnmodemap::AbstractArray{Float64,2} | |||
| qtbtd::AbstractArray{Float64,2} | |||
There was a problem hiding this comment.
Can we pick a less cryptic name? Is this for half assembly?
There was a problem hiding this comment.
Ja genau, qtbtd seems too cryptic
|
Note - CI was changed on the main branch, so this branch will need to be rebased in order to be mergable |
|
Ok, thanks for the head up. |
No description provided.